4.x update for Kotlin 2.2.10 #140
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* updated the gradle wrapper to 8.14 * updated Kotlin (and friends) to what fabric-language-kotlin version 1.13.5+kotlin.2.2.10 provides * fixed `forge/kfflib/src/test/kotlin/thedarkcolour/kfflibtest/InGameTester.kt` (implementing the *sane* API changes from <MinecraftForge/MinecraftForge@90dafb0>) * ported `forge/kfflib/src/test` to NeoForge * copied nonmclibs configuration to kfflib (to run the tests) * overwrote the `org.jetbrains:annotations` version to fix a JPMS module issue where version 13 and 23+ clashed on the classpath * bumped the version to 4.12.0
bziemons
force-pushed
the
4.x-fix-update-kotlin-2.2.10
branch
from
1db9571 to
29e6adf
Compare
|
This would be awesome! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I am not sure if this PR is even worth creating, because I do not know whether 4.x should still be supported. I also do not know, if all the changes are made were necessary, but I struggled quite a bit getting the included NeoForge 1.20.4 run configurations to work and getting Gradle to like my changes. Sorry for the mess, but I saw this was cleaned up for the 5.x branch anyway.
I successfully tested the changes with the ported NeoForge gametests in 1.20.4 and with the mod I am working with on LexForge 1.20.1. It would be great to have this available here in upstream.
To summarise my changes:
cleaned up the manifests having multiple different module names (first issue)forge/kfflib/src/test/kotlin/thedarkcolour/kfflibtest/InGameTester.kt(implementing the sane API changes from MinecraftForge/MinecraftForge@90dafb0)forge/kfflib/src/testto NeoForgeorg.jetbrains:annotationsversion to fix another JPMS module issue where version 13 and 23+ clashed on the classpath